Improved performance of UriParser#extractScheme #614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UriParser#extractScheme
is often called, so performance of this method matters.Here is a performance improvement that avoids many String concatenation.
Here are the JMH results
Before
Benchmark Mode Cnt Score Error Units
UriParserBenchmark.extractScheme thrpt 25 86408837,361 ▒ 3001538,949 ops/s
After
Benchmark Mode Cnt Score Error Units
UriParserBenchmark.extractScheme thrpt 25 159851495,299 ▒ 2540759,982 ops/s
JMH results show a 85% performance improvement of the method
Also attached a flame graph of
![profiling-UriParser-extract-scheme](https://private-user-images.githubusercontent.com/318821/373882769-865a7efa-7de5-4d3f-a656-e79f82516af7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzgxNTgsIm5iZiI6MTczOTA3Nzg1OCwicGF0aCI6Ii8zMTg4MjEvMzczODgyNzY5LTg2NWE3ZWZhLTdkZTUtNGQzZi1hNjU2LWU3OWY4MjUxNmFmNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwNTEwNThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NGY0MzA3ZjZkNmQ5MDNlZDk3NGRlYWM5NWNjMDE3ZGVjODgyZGMyYTIzZDk4MTUzZTUxNTg4NjhhN2U4ZTEyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.kXfIBcEfj0tLWEawPqocovGE4MgtSgPYfx2KEcQDdXQ)
![profiling-UriParser-extract-scheme-crop](https://private-user-images.githubusercontent.com/318821/373882775-308202f0-0b0b-4494-9627-79d03d70f06f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzgxNTgsIm5iZiI6MTczOTA3Nzg1OCwicGF0aCI6Ii8zMTg4MjEvMzczODgyNzc1LTMwODIwMmYwLTBiMGItNDQ5NC05NjI3LTc5ZDAzZDcwZjA2Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwNTEwNThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNzdiZTYyMjNmMjgwYTVmOGJlYmQyMzA5MjkzZWQwODUzMDc1OTY1ZmIxODU5OWEwNWU5NDhmZjdhYTM1NmQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.mLq7ldnLwHfeBmEl4-ZOw1OEigznrH4U-0LStETMZk4)
FileObject#getChildren()
using JFR/JMC showing that most of the time is spent in theextractScheme
method