Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
Android and iOS plugins have a "keep callback" option that let us send multiple responses like an observable.
In Electron this feature doesn't exist yet.
Android plugin example:
I found this problem when I tried to build a plugin that sends events when a USB is connected/disconnected.
Description
I tried to find a solution that doesn't break existing plugins, and decided to add a new exec$ method.
The $ is used to identify which functions could return multiple values.
The exec$ method, instead of using
ipcRenderer.invoke()
, usesipcRenderer.on()
andipcRenderer.send()
with a new channelcdv-plugin-exec$
. To identify requests, a unique ID is usedDate.now() + Math.random()
(this should be random enough).Testing
I have run
npm run test
.I have also added an example in this plugin
tests/spec/fixtures/test-app-with-electron-plugin/plugins/cordova-plugin-sample
.I don't know if there is currently a way to automatically test code inside path
tests/spec/fixtures
.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)