GH-240 electron: Allow passing all platform options to electron-builder #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Electron (Mac/Win/Linux)
Motivation and Context
Fixes #240.
electron-builder
allows options to be passed which enable auto-updating, among other things.Cordova-Electron was unnecessarily restricting the passing of options in the platform configs which prevented the use of these extra configuration options and features of
electron-builder
.The tests for cordova-electron were not catching this as they only tested each individual unit rather than the integrated code-flow.
Description
Removing the function
__validateUserPlatformBuildSettings
and it's call inlib/build.js
enables the use of these extra config keys. Any errors caused by incorrect config keys should be caught byelectron-builder
itself, negating the need for this check.Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)