Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-240 electron: Allow passing all platform options to electron-builder #244

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RaddishIoW
Copy link

@RaddishIoW RaddishIoW commented Oct 20, 2022

Platforms affected

Electron (Mac/Win/Linux)

Motivation and Context

Fixes #240.
electron-builder allows options to be passed which enable auto-updating, among other things.
Cordova-Electron was unnecessarily restricting the passing of options in the platform configs which prevented the use of these extra configuration options and features of electron-builder.

The tests for cordova-electron were not catching this as they only tested each individual unit rather than the integrated code-flow.

Description

Removing the function __validateUserPlatformBuildSettings and it's call in lib/build.js enables the use of these extra config keys. Any errors caused by incorrect config keys should be caught by electron-builder itself, negating the need for this check.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@RaddishIoW RaddishIoW marked this pull request as ready for review October 20, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pass Publish options to electron-builder
1 participant