Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove extra array wrapper from passed arguments #266

Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 20, 2024

Platforms affected

electron

Motivation and Context

Arguments passed to plugins were accidentally being double-wrapped. This update properly removes the wrapping so that plugin developers don't always have to read from index [0]. Additionally, other platforms did not have this double wrapping.

Description

Updated the IPC handler to expand the args that are passed to plugins.

Testing

  • npm t
  • cordova build electron
  • cordova run electron --nobuild

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu force-pushed the fix/remove-double-wrapped-params-for-plugins branch from d329897 to bcc2c5b Compare February 20, 2024 13:43
@erisu erisu merged commit 40227e1 into apache:master Feb 20, 2024
3 checks passed
@erisu erisu deleted the fix/remove-double-wrapped-params-for-plugins branch February 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants