feat: Implement CAST from struct to string #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuyukitanimura
approved these changes
Nov 8, 2024
| // https://github.com/apache/datafusion-comet/issues/1067 is resolved | ||
| // checkSparkAnswerAndOperator( | ||
| // "SELECT CAST(struct(_9, _10, _11, _12) as string) FROM tbl") | ||
| // decimals (_16 intentionally excluded due to formatting difference with scientific notation) |
There was a problem hiding this comment.
Let's file an issue for _16? Not sure if it is related to struct or independent decimal issue.;
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=============================================
+ Coverage 34.46% 54.82% +20.35%
+ Complexity 888 858 -30
=============================================
Files 113 110 -3
Lines 43580 10760 -32820
Branches 9658 2089 -7569
=============================================
- Hits 15021 5899 -9122
+ Misses 25507 3807 -21700
+ Partials 3052 1054 -1998 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #814
Rationale for this change
As we add support for complex types, we will need to support CASTing them to string, so that users can run
df.show()for example.What changes are included in this PR?
Implement CAST from struct to string
How are these changes tested?