Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use RDD partition index #1112

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix: Use RDD partition index #1112

merged 4 commits into from
Nov 25, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 23, 2024

Which issue does this PR close?

Closes #1113.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.35%. Comparing base (b74bfe4) to head (df545c5).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ain/scala/org/apache/comet/CometExecIterator.scala 75.00% 0 Missing and 1 partial ⚠️
...la/org/apache/spark/sql/comet/CometExecUtils.scala 66.66% 0 Missing and 1 partial ⚠️
...ark/sql/comet/CometTakeOrderedAndProjectExec.scala 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1112      +/-   ##
============================================
+ Coverage     34.33%   34.35%   +0.01%     
  Complexity      898      898              
============================================
  Files           115      115              
  Lines         42986    43416     +430     
  Branches       9369     9499     +130     
============================================
+ Hits          14761    14917     +156     
- Misses        25361    25585     +224     
- Partials       2864     2914      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@viirya viirya merged commit 5400fd7 into apache:main Nov 25, 2024
74 checks passed
@viirya
Copy link
Member Author

viirya commented Nov 25, 2024

Thanks @andygrove

@viirya viirya deleted the fix_partition_index branch November 25, 2024 07:13
viirya added a commit to viirya/arrow-datafusion-comet that referenced this pull request Nov 25, 2024
* fix: Use RDD partition index

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CometExecIterator uses incorrect partition index
3 participants