-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [branch-0.6] Fix Comet version in Spark diffs #1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about .github/actions/setup-spark-builder/action.yaml
?
The title says |
Thanks. Updated. |
There is no need to override the default value since it gets replace dynamically, but I filed an issue to remove these hard-coded versions: #1406 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-0.6 #1405 +/- ##
=============================================
Coverage ? 39.18%
Complexity ? 2077
=============================================
Files ? 265
Lines ? 60992
Branches ? 12964
=============================================
Hits ? 23900
Misses ? 32587
Partials ? 4505 ☔ View full report in Codecov by Sentry. |
nm, I have updated it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue does this PR close?
Fix incorrect Comet version in Spark diffs.
Rationale for this change
Fixing this just in case anyone wants to run Spark SQL tests locally from this branch. The tests already run correctly in CI because the Comet version is provided dynamically at runtime.
What changes are included in this PR?
How are these changes tested?