Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [branch-0.6] Fix Comet version in Spark diffs #1405

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Fix incorrect Comet version in Spark diffs.

Rationale for this change

Fixing this just in case anyone wants to run Spark SQL tests locally from this branch. The tests already run correctly in CI because the Comet version is provided dynamically at runtime.

What changes are included in this PR?

How are these changes tested?

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about .github/actions/setup-spark-builder/action.yaml?

@kazuyukitanimura
Copy link
Contributor

The title says [branch-0.6] but this PR is against main?

@andygrove andygrove changed the base branch from main to branch-0.6 February 15, 2025 01:35
@andygrove
Copy link
Member Author

The title says [branch-0.6] but this PR is against main?

Thanks. Updated.

@andygrove
Copy link
Member Author

What about .github/actions/setup-spark-builder/action.yaml?

There is no need to override the default value since it gets replace dynamically, but I filed an issue to remove these hard-coded versions: #1406

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-0.6@b735f2d). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             branch-0.6    #1405   +/-   ##
=============================================
  Coverage              ?   39.18%           
  Complexity            ?     2077           
=============================================
  Files                 ?      265           
  Lines                 ?    60992           
  Branches              ?    12964           
=============================================
  Hits                  ?    23900           
  Misses                ?    32587           
  Partials              ?     4505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andygrove
Copy link
Member Author

What about .github/actions/setup-spark-builder/action.yaml?

There is no need to override the default value since it gets replace dynamically, but I filed an issue to remove these hard-coded versions: #1406

nm, I have updated it

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 6a0d0ed into apache:branch-0.6 Feb 18, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants