Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Comet native operator can be executed after ReusedExchange #187

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 11, 2024

Which issue does this PR close?

Closes #188.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 33.29%. Comparing base (488c523) to head (1a28b45).

Files Patch % Lines
...n/scala/org/apache/spark/sql/comet/operators.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #187   +/-   ##
=========================================
  Coverage     33.29%   33.29%           
- Complexity      766      767    +1     
=========================================
  Files           107      107           
  Lines         35385    35385           
  Branches       7658     7658           
=========================================
+ Hits          11781    11782    +1     
  Misses        21157    21157           
+ Partials       2447     2446    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit 7ba69d8 into apache:main Mar 11, 2024
21 checks passed
@viirya
Copy link
Member Author

viirya commented Mar 11, 2024

Merged. Thanks.

@viirya viirya deleted the fix_reused_exchange branch March 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comet native operator cannot be executed after ReusedExchange
3 participants