feat: Document the class path / classloader issue with the shuffle manager #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holdenk
changed the title
andygrove
reviewed
Apr 11, 2024
spark/src/main/java/org/apache/spark/shuffle/sort/CometShuffleExternalSorter.java
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Apr 11, 2024
Co-authored-by: Andy Grove <[email protected]>
…ExternalSorter.java Co-authored-by: Andy Grove <[email protected]>
viirya
reviewed
Apr 11, 2024
| Depending on your deployment mode you may also need to set the driver & executor class path(s) to explicitly contain Comet otherwise Spark may use a different class-loader for the Comet components than its internal components which will then fail at runtime. For example: | ||
|
|
||
| ``` | ||
| --driver-class-path spark/target/comet-spark-spark3.4_2.12-0.1.0-SNAPSHOT.jar |
There was a problem hiding this comment.
Maybe also add executor configuration alongside? Although it is trivial but as we already go to update this.
viirya
reviewed
Apr 11, 2024
viirya
approved these changes
Apr 11, 2024
sunchao
approved these changes
Apr 11, 2024
Co-authored-by: Liang-Chi Hsieh <[email protected]>
|
Merged, thanks! |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #221
Rationale for this change
The class loader exception that you get when this is not configured is confusing.
What changes are included in this PR?
Documentation change + wrapped exception pointing to the documentation.
How are these changes tested?
Ran with different launch flags.