fix: incorrect result on Comet multiple column distinct count #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Apr 15, 2024
Comment on lines
1097
to
1105
| let mut children = vec![]; | ||
| for child in expr.children.iter() { | ||
| children.push(self.create_expr(child, schema.clone())?); | ||
| } | ||
| Ok(Arc::new(Count::new_with_multiple_exprs( | ||
| children, | ||
| "count", | ||
| DataType::Int64, | ||
| ))) |
There was a problem hiding this comment.
Count could take multiple children, but we used one child only.
|
cc @andygrove |
huaxingao
approved these changes
Apr 15, 2024
andygrove
reviewed
Apr 15, 2024
andygrove
approved these changes
Apr 15, 2024
Co-authored-by: Andy Grove <[email protected]>
|
Merged. Thanks. |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…#268) * fix: incorrect result on Comet multiple column distinct count * Update core/src/execution/datafusion/planner.rs Co-authored-by: Andy Grove <[email protected]> --------- Co-authored-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #267.
Rationale for this change
What changes are included in this PR?
How are these changes tested?