Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for BNLJ #343

Closed
wants to merge 1 commit into from

Conversation

singhpk234
Copy link

Which issue does this PR close?

Closes #.#198

Rationale for this change

What changes are included in this PR?

Support for BNLJ, this supports is missing in supported joins

How are these changes tested?

UT

@andygrove
Copy link
Member

Thanks for the contribution @singhpk234. I see this is marked WIP so will hold off on reviewing until it is ready for review. Let us know if you need any help or have questions.

@viirya
Copy link
Member

viirya commented Jun 12, 2024

I saw this is in WIP for a while. @singhpk234 Would you like to continue working on it? Or we can have someone take it over? Thanks.

@singhpk234
Copy link
Author

Apologies @andygrove @viirya got swamped by internal company work and lost track of this pr, i would able to make it ready for review by EOW for sure (thinking of utilizing this weekend for the same) if it's fine ?

@viirya
Copy link
Member

viirya commented Jun 13, 2024

No worries. Just want to make sure if you still work on it. If not, we could have someone pick it up. Thanks.

@singhpk234
Copy link
Author

singhpk234 commented Jun 13, 2024

Thanks @viirya for sure I am on it from now !

@andygrove
Copy link
Member

Moving this to draft for now since it has been inactive for a while

@andygrove andygrove marked this pull request as draft August 13, 2024 16:32
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
@andygrove
Copy link
Member

@singhpk234 I will close this PR for now since it has been inactive for a while. Feel free to reopen this or create a new PR if you continue work on this.

@andygrove andygrove closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants