Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cargo machete to remove udeps #641

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

vaibhawvipul
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Removing unused dependencies. Better for streamlining the project and frees up space.

What changes are included in this PR?

Adding cargo machete to CI.

How are these changes tested?

Build succeeds. All tests pass.

@vaibhawvipul vaibhawvipul marked this pull request as ready for review July 8, 2024 16:00
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Thanks @vaibhawvipul

@vaibhawvipul vaibhawvipul changed the title add cargo machete to remove udeps feat: add cargo machete to remove udeps Jul 8, 2024
@vaibhawvipul
Copy link
Contributor Author

CI failed because of network error . Can we do a re-run?

@viirya
Copy link
Member

viirya commented Jul 8, 2024

CI failed because of network error . Can we do a re-run?

Sure. Triggered a re-run.

@andygrove andygrove merged commit 8f4427a into apache:main Jul 8, 2024
74 of 75 checks passed
@vaibhawvipul vaibhawvipul deleted the remove-udeps branch July 9, 2024 02:37
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants