feat: Move IfExpr to spark-expr crate
#653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
IfExpr to spark-expr crate
andygrove
commented
Jul 10, 2024
Comment on lines
+159
to
+166
| /// Create an If expression | ||
| fn if_fn( | ||
| if_expr: Arc<dyn PhysicalExpr>, | ||
| true_expr: Arc<dyn PhysicalExpr>, | ||
| false_expr: Arc<dyn PhysicalExpr>, | ||
| ) -> Result<Arc<dyn PhysicalExpr>> { | ||
| Ok(Arc::new(IfExpr::new(if_expr, true_expr, false_expr))) | ||
| } |
There was a problem hiding this comment.
This function is only used in tests, so I moved it into the test module.
viirya
reviewed
Jul 11, 2024
|
|
||
| # datafusion-comet-utils | ||
|
|
||
| This crate provides utilities for use in the [Apache DataFusion Comet](https://github.com/apache/datafusion-comet/) project. |
viirya
approved these changes
Jul 11, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #630
Rationale for this change
Move another Spark expr into the spark-expr crate
What changes are included in this PR?
datafusion-comet-utilscrateHow are these changes tested?
Existing tests.