Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix jdk documentation for spark #979

Closed
wants to merge 5 commits into from

Conversation

adi-kmt
Copy link

@adi-kmt adi-kmt commented Sep 28, 2024

Which issue does this PR close?

Closes

Closes #742

Rationale for this change

<-- -->

What changes are included in this PR?

Changed the installation.md and

How are these changes tested?

Just documentation change.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adi-kmt

@adi-kmt adi-kmt changed the title Fix jdk documentation for spark chore: Fix jdk documentation for spark Sep 28, 2024
@adi-kmt adi-kmt requested a review from viirya September 29, 2024 05:29
@adi-kmt adi-kmt requested a review from viirya September 29, 2024 06:06
### Supported Apache Spark Versions
For more details, refer to the documentation: [Apache Spark supported by Comet](overview.md#supported-apache-spark-versions)

- **Apache Spark 3.3, 3.4, or 3.5**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to remove duplications in doc for Supported Apache Versions @adi-kmt Is there any specific reason of having this duplication?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main motive was to indicate the different jdk versions wrt to the apache spark versions. Do you think it could be written in a better way?


- **Apache Spark 3.3, 3.4, or 3.5**
- **Supported Java Versions**: JDK 8 and above
- **GLIBC**: 2.17 (CentOS 7) and above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our latest release is built on Ubuntu 20.04 which has glibc 2.31. Could we update that here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For pre-built binary release, we can mention what glibc we use. Although I think it doesn't mean older glibc is not supported, users still can build by themselves and use older glibc.

@comphead
Copy link
Contributor

@adi-kmt please resolve the conflict

@@ -30,17 +30,22 @@ Make sure the following requirements are met and software installed on your mach

### Supported Spark Versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Supported Spark Versions

- **Scala**: 2.12/2.13
- **Apache Spark 4.0** *(Experimental Support - is intended for development/testing use only and should not be used in production yet.)*
- **Supported Java Versions**: JDK 17/21
- **GLIBC**: 2.17 (CentOS 7) and above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for GLIBC Im thinking if its good to specify a Linux distribution... I would leave just a version and put a command to check GLIBC like ldd --version

@adi-kmt adi-kmt closed this by deleting the head repository Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update supported Spark and Java versions in installation guide
5 participants