feat: remove DataFusion pyarrow feat #1000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rename DataFusionError to PyDataFusionError to be less confusing
FWIW this is also one of the reasons why I created pyo3-arrow: https://docs.rs/pyo3-arrow/latest/pyo3_arrow/#why-not-use-arrow-rss-python-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This addresses part of apache/datafusion#14197
Rationale for this change
By removing the
pyarrowdependency of DataFusion we can updatepyo3in without requiring corresponding updates to the DataFusion core repository. This does add in a few additional pieces, such as adding a wrapper aroundScalarValue, but it will simplify the core DataFusion repo to not have pyo3 in it.What changes are included in this PR?
pyarrowfeature of DataFusion core repoPyScalarValuewhich is a simple wrapper onScalarValueso we can do things like implement traits on it that are currently implemented upstream in DataFusion.DataFusionErrortoPyDataFusionErrorso there is not confusion with the enum defined upstream.Are there any user-facing changes?
No user facing changes.