feat: add cast to DataFrame
#916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
reviewed
Oct 13, 2024
Yess, we need to merge in that order |
timsaucer
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A top level cast is very practical and a common practice to do, since it's just a projection of columns, we call with_columns underneath. Therefore it builds on top of: #909, so that one needs to be merged first.
What changes are included in this PR?
castmethod which takes in a mapping of col_names and dtypes.Important: I am going to work soon on creating a datafusion-python native schema struct and classes. Because going to pyarrow is simply to painful :) and then we can also drop the pyarrow dependency for that part
Are there any user-facing changes?