-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async iteration of RecordBatchStream #975
Support async iteration of RecordBatchStream #975
Conversation
If this looks good, we can add a test using pytest-asyncio |
At first glance, this looks like a very nice add. Do you need help resolving the test failures? |
I'd like to add a test with pytest-asyncio, but I don't know how to add the dependency, ref #977 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I've had a chance to actually review, this looks great. Can we add an issue to track the unit test for pytest-asyncio after the update to uv
for package management?
…ate the type hint.
Which issue does this PR close?
Closes #974 .
Rationale for this change
Support async iteration of RecordBatchStream.
What changes are included in this PR?
StopIteration
orAsyncStopIteration
errorsSendableRecordBatchStream
into anArc<Mutex<>>
. This is required I think so that we can clone the stream intofuture_into_py
Are there any user-facing changes?
Adds async iterator support.