Skip to content

Commit

Permalink
Rename spill pool test functions for clarity and consistency
Browse files Browse the repository at this point in the history
  • Loading branch information
kosiew committed Jan 3, 2025
1 parent 04d9123 commit 242f5ab
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions datafusion/core/src/dataframe/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2755,7 +2755,7 @@ mod tests {
}

// test for https://github.com/apache/datafusion/issues/13949
async fn run_test_with_spill_pool(pool_size: usize) -> Result<()> {
async fn run_test_with_spill_pool_if_necessary(pool_size: usize) -> Result<()> {
fn create_record_batch(
schema: &Arc<Schema>,
data: (Vec<u32>, Vec<f64>),
Expand Down Expand Up @@ -2844,11 +2844,11 @@ mod tests {
}

#[tokio::test]
async fn test_aggregate_with_spill() -> Result<()> {
async fn test_aggregate_with_spill_if_necessary() -> Result<()> {
// test with spill
run_test_with_spill_pool(1600).await?;
run_test_with_spill_pool_if_necessary(1600).await?;
// test without spill
run_test_with_spill_pool(16000).await?;
run_test_with_spill_pool_if_necessary(16000).await?;
Ok(())
}

Expand Down

0 comments on commit 242f5ab

Please sign in to comment.