Skip to content

Commit

Permalink
Do not hardcode test names
Browse files Browse the repository at this point in the history
  • Loading branch information
blaginin committed Dec 13, 2024
1 parent 9cb1c99 commit 53c9c51
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions datafusion-cli/tests/cli_integration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ fn cli_quick_test<'a>(
let mut cmd = cli();
cmd.args(args);

assert_cmd_snapshot!("cli_quick_test", cmd);
assert_cmd_snapshot!(cmd);
}

#[rstest]
Expand All @@ -90,7 +90,7 @@ fn test_cli_format<'a>(#[case] format: &'a str) {
let mut cmd = cli();
cmd.args(["--command", "select 1", "-q", "--format", format]);

assert_cmd_snapshot!("cli_format", cmd);
assert_cmd_snapshot!(cmd);
}

async fn s3_client() -> aws_sdk_s3::Client {
Expand Down Expand Up @@ -187,7 +187,7 @@ async fn test_cli() {

glob!("sql/*.sql", |path| {
let input = fs::read_to_string(path).unwrap();
assert_cmd_snapshot!("cli", cli().pass_stdin(input))
assert_cmd_snapshot!(cli().pass_stdin(input))
});
}

Expand Down Expand Up @@ -235,5 +235,5 @@ SELECT * FROM CARS limit 1;
access_key_id, secret_access_key, endpoint_url
);

assert_cmd_snapshot!("aws_options", cli().env_clear().pass_stdin(input));
assert_cmd_snapshot!(cli().env_clear().pass_stdin(input));
}
2 changes: 1 addition & 1 deletion datafusion-cli/tests/snapshots/aws_options.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source: tests/cli_integration.rs
info:
program: datafusion-cli
args: []
stdin: "CREATE EXTERNAL TABLE CARS\nSTORED AS CSV\nLOCATION 's3://datafusion/test_aws_options/cars.csv'\nOPTIONS(\n 'aws.access_key_id' 'TEST-DataFusionLogin',\n 'aws.secret_access_key' 'TEST-DataFusionPassword',\n 'aws.endpoint' 'http://127.0.0.1:9000',\n 'aws.allow_http' 'true'\n);\n\nSELECT * FROM CARS limit 1;\n"
stdin: "CREATE EXTERNAL TABLE CARS\nSTORED AS CSV\nLOCATION 's3://options/cars.csv'\nOPTIONS(\n 'aws.access_key_id' 'TEST-DataFusionLogin',\n 'aws.secret_access_key' 'TEST-DataFusionPassword',\n 'aws.endpoint' 'http://127.0.0.1:9000',\n 'aws.allow_http' 'true'\n);\n\nSELECT * FROM CARS limit 1;\n"
---
success: true
exit_code: 0
Expand Down

0 comments on commit 53c9c51

Please sign in to comment.