Skip to content

Commit

Permalink
Increase ByteViewMap block size to 2MB (#11674)
Browse files Browse the repository at this point in the history
* better default block size

* fix related test
  • Loading branch information
XiangpengHao authored Jul 27, 2024
1 parent 281fbed commit 5690712
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions datafusion/physical-expr-common/src/binary_view_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ where
output_type,
map: hashbrown::raw::RawTable::with_capacity(INITIAL_MAP_CAPACITY),
map_size: 0,
builder: GenericByteViewBuilder::new(),
builder: GenericByteViewBuilder::new().with_block_size(2 * 1024 * 1024),
random_state: RandomState::new(),
hashes_buffer: vec![],
null: None,
Expand Down Expand Up @@ -545,7 +545,7 @@ mod tests {
// Much larger strings in strings2
let strings2 = StringViewArray::from(vec![
"FOO".repeat(1000),
"BAR larger than 12 bytes.".repeat(1000),
"BAR larger than 12 bytes.".repeat(100_000),
"more unique.".repeat(1000),
"more unique2.".repeat(1000),
"FOO".repeat(3000),
Expand Down

0 comments on commit 5690712

Please sign in to comment.