Skip to content

Commit

Permalink
Unify CI and pre-commit hook settings for clippy (#11640)
Browse files Browse the repository at this point in the history
pre-commit hook runs clippy and CI scripts run clippy too. The commands
are and should be the same. Let's define them once.
  • Loading branch information
findepi authored Jul 24, 2024
1 parent 20b298e commit 76039fa
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions pre-commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,7 @@ fi
# 1. cargo clippy

echo -e "$(GREEN INFO): cargo clippy ..."

# Cargo clippy always return exit code 0, and `tee` doesn't work.
# So let's just run cargo clippy.
cargo clippy --all-targets --workspace --features avro,pyarrow -- -D warnings
pushd datafusion-cli
cargo clippy --all-targets --all-features -- -D warnings
popd
./ci/scripts/rust_clippy.sh
echo -e "$(GREEN INFO): cargo clippy done"

# 2. cargo fmt: format with nightly and stable.
Expand Down

0 comments on commit 76039fa

Please sign in to comment.