Support explicit type and name during table creation #10273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongcongtoai
changed the title
duongcongtoai
commented
Apr 28, 2024
Cargo.toml
Outdated
| @@ -103,7 +103,7 @@ parquet = { version = "51.0.0", default-features = false, features = ["arrow", " | |||
| rand = "0.8" | |||
| rstest = "0.19.0" | |||
| serde_json = "1" | |||
| sqlparser = { version = "0.45.0", features = ["visitor"] } | |||
| sqlparser = { git = "https://github.com/duongcongtoai/sqlparser-rs", rev = "62f1e02f4a7d5160e8538b34f30e311905b4a72a", features = ["visitor"] } | |||
There was a problem hiding this comment.
temp commithash
|
waiting for sql-parser upgrade in this PR: #10392 |
|
hi @jayzhan211 the PR is ready for review, but the syntax is bigquery-liked. Do you need the syntax of duckdb to complete this issue? |
It would be nice to support DuckDB-like syntax, aligning with PostgreSQL and DuckDB conventions unless a better alternative is available. |
|
ok, i'm working on it |
alamb
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Thank you for the contribution @duongcongtoai -- this looks great to me 🙏
|
|
||
| # named and named less struct fields | ||
| statement ok | ||
| CREATE TABLE struct_values ( |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* temp cargo commit * chore: update test * fmt * update cli cargo lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10207 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?