Optionally display schema in explain plan #11177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Jun 29, 2024
| InitialPhysicalPlanWithStats, | ||
| ), | ||
| ); | ||
| // Show statistics + schema in verbose output even if not |
There was a problem hiding this comment.
The amount of code required for this change is unfortunate, and I am sure we could make it better, but it was pretty mechanical
alamb
commented
Jun 29, 2024
| EXPLAIN SELECT a, b, c FROM simple_explain_test; | ||
| ---- | ||
| logical_plan TableScan: simple_explain_test projection=[a, b, c] | ||
| physical_plan CsvExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/core/tests/data/example.csv]]}, projection=[a, b, c], has_header=true, schema=[a:Int32;N, b:Int32;N, c:Int32;N] |
There was a problem hiding this comment.
This shows how the schema is displayed (schema=[[a:Int32;N, b:Int32;N, c:Int32;N]])
|
Thank you for the review @jayzhan211 |
10 tasks
9 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11176
Rationale for this change
In the context of:
StringViewin DataFusion #10918I have been contemplating adding optimizations that changes DataTypes between certain operators (e.g. to DictionaryArray or StringArray)
Thus I would like to be able to see the schema in the query plans as part of that project
What changes are included in this PR?
set datafusion.explain.show_schema = true;optionAre these changes tested?
Yes
Are there any user-facing changes?
A new config option and more information in verbose explain plans