Minor: Use upstream concat_batches from arrow-rs
#11615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ozankabak mentioned #11610 (comment) there was work in progress for |
alamb
commented
Jul 23, 2024
| batches.len(), | ||
| row_count | ||
| ); | ||
| arrow::compute::concat_batches(schema, batches) |
There was a problem hiding this comment.
The existing function simply wraps concat_batches in arrow and logs some information which I don't think is critical. Note that the row_count is only used for the logging. If reviewers think the trace! is valuable, I will put it back (at the callsites)
Dandandan
reviewed
Jul 23, 2024
| @@ -364,7 +364,7 @@ async fn collect_left_input( | |||
| let stream = merge.execute(0, context)?; | |||
|
|
|||
| // Load all batches and count the rows | |||
| let (batches, num_rows, metrics, mut reservation) = stream | |||
| let (batches, _num_rows, metrics, mut reservation) = stream | |||
There was a problem hiding this comment.
The calculation of _num_rows can be removed here now...
There was a problem hiding this comment.
good call -- will do as a follow on PR
andygrove
approved these changes
Jul 23, 2024
Dandandan
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While working on #11610 I found that there is a wrapper over
concat_batchesThe concat batches function is now available in arrow-rs so let's use that
What changes are included in this PR?
Use arrow concat_batches directly rather than via a wrapper
Are these changes tested?
By existing CI
Are there any user-facing changes?
No