Support partial aggregation skip for boolean functions #11847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW #11825 is merged |
alamb
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Thank yoU @2010YOUY01 -- this makes sense to me 🙏
💯 for thorough testing
cc @korowa in case you are interested in how the partial aggregation skipping is propagating through the codebase
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11818
Rationale for this change
Support partial aggregation skip (introduced in #11627) in
bool_or(),bool_and()aggregate function.What changes are included in this PR?
convert_to_state()interface for boolean grouped aggregate function.Remaining tasks
More tests after fixingPotential bug inbool_and()aggregate function #11846filtered_null_maskfollowing Usefiltered_null_maskinCountGroupsAccumulatorandPrimitiveGroupsAccumulator#11825Are these changes tested?
Yes
Are there any user-facing changes?
No