Implement native support StringView for find in set #11970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chojan Shang <[email protected]>
alamb
approved these changes
Aug 13, 2024
| @@ -913,7 +913,7 @@ EXPLAIN SELECT | |||
| FROM test; | |||
| ---- | |||
| logical_plan | |||
| 01)Projection: find_in_set(CAST(test.column1_utf8view AS Utf8), Utf8("a,b,c,d")) AS c | |||
There was a problem hiding this comment.
I think we should probably add a test that actually invokes find_in_set with a StringVieAwArray argument.
However, I think @2010YOUY01 has some ideas on a more general testing framework, so maybe this is good enough for now. Let me know what you think
There was a problem hiding this comment.
I will add some sqllogictests to make sure it is covered.
Signed-off-by: Chojan Shang <[email protected]>
alamb
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11954 .
Rationale for this change
Ref: https://github.com/apache/datafusion/blob/main/datafusion/functions/src/unicode/character_length.rs
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?