Require Debug for TableProvider, TableProviderFactory and PartitionStream
#12557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
phillipleblanc
approved these changes
Sep 20, 2024
|
Thank you @phillipleblanc |
alamb
changed the title
Debug for TableProvider, TableProviderFactory and PartitionStream`Debug for TableProvider, TableProviderFactory and PartitionStream
timsaucer
approved these changes
Sep 25, 2024
|
Thank you @timsaucer 🙏 @phillipleblanc and @goldmedal |
andygrove
approved these changes
Sep 25, 2024
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
…itionStream` (apache#12557) * Require `Debug` for `TableProvider, ``TableProviderFactory` and `PartitionStream` * add another debug * fix doc test * Update to use non deprecated API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12555
Rationale for this change
I would like DataFusion to be easiser to configure and use, and having
Debugimpls forcommon structs would be a big help.
What changes are included in this PR?
DebugforTableProvider,TableProviderFactoryandPartitionStream`Are these changes tested?
Yes, by CI and compiler
Are there any user-facing changes?
Technically this is an API change as it also adds the requirement for Debug to anything that implements
TableProvider, ``TableProviderFactoryorPartitionStream