Minor: add documentation note about NullState
#12791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
NullState
lewiszlw
reviewed
Oct 8, 2024
github-actions
bot
removed
the
documentation
alamb
commented
Oct 8, 2024
| @@ -17,21 +17,6 @@ | |||
| //! [`Max`] and [`MaxAccumulator`] accumulator for the `max` function | |||
| //! [`Min`] and [`MinAccumulator`] accumulator for the `min` function | |||
|
|
|||
| // distributed with this work for additional information | |||
There was a problem hiding this comment.
The license header is already in this file -- I am not sure why there is a second partial copy of the header here so I removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While working on #6906 with @devanbenz it was not always clear that much of the complexity related to null handling in
GroupsAccumulatorcan be handled byNullStateWhat changes are included in this PR?
GroupsAccumulatorcommentsAre these changes tested?
Yes, by CI
Are there any user-facing changes?
Just documentation