Implement native support StringView for REGEXP_LIKE
#12897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm365
force-pushed
the
regex-like-strview
branch
from
481a393 to
fae6d88
Compare
Signed-off-by: Tai Le Manh <[email protected]>
tlm365
force-pushed
the
regex-like-strview
branch
from
fae6d88 to
899fb7f
Compare
findepi
approved these changes
Oct 12, 2024
|
cc @alamb |
Omega359
reviewed
Oct 12, 2024
| @@ -727,7 +727,7 @@ EXPLAIN SELECT | |||
| FROM test; | |||
| ---- | |||
| logical_plan | |||
| 01)Projection: regexp_like(CAST(test.column1_utf8view AS Utf8), Utf8("^https?://(?:www\.)?([^/]+)/.*$")) AS k | |||
| 01)Projection: regexp_like(test.column1_utf8view, Utf8("^https?://(?:www\.)?([^/]+)/.*$")) AS k | |||
|
LGTM as well. |
alamb
approved these changes
Oct 16, 2024
| TypeSignature::Exact(vec![LargeUtf8, LargeUtf8]), | ||
| TypeSignature::Exact(vec![Utf8View, Utf8, Utf8]), |
There was a problem hiding this comment.
I think requiring the flags array to be StringArrray (aka only supporting Utf8 as the third argument) makes lots of sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11910.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?