fix: Update TO_DATE, TO_TIMESTAMP scalar functions to support LargeUtf8, Utf8View #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew. Benchmark updated as well
findepi
approved these changes
Oct 15, 2024
| query P | ||
| SELECT to_timestamp(t.ts, '%Y-%m-%d %H/%M/%S%#z', '%+', '%s', '%d-%m-%Y %H:%M:%S%#z') from ts_utf8_data as t |
There was a problem hiding this comment.
hmm. Incorrect refactor ... I changed the sql a few times here to condense the tests and it looks like I may have inadvertently changed this.
There was a problem hiding this comment.
Actually, it's now part of the sql starting at line 2242
alamb
approved these changes
Oct 15, 2024
| format1_builder.append_value("%+"); | ||
| format2_builder.append_value("%c"); | ||
| format3_builder.append_value("%Y-%m-%d 00:00:00"); | ||
| c.bench_function("to_timestamp_with_formats_utf8", |b| { |
|
I merged up from main and applied @findepi 's comment suggestion. Once the tests pass I think this one is good to go |
|
🚀 |
Omega359
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12928
Rationale for this change
Update functions to support Utf8View and LargeUtf8
What changes are included in this PR?
Code, tests, benchmark
Are these changes tested?
Yes
Are there any user-facing changes?
No