Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC: Remove unnecessary null check for GroupColumn #12947

Closed
wants to merge 28 commits into from
Closed

POC: Remove unnecessary null check for GroupColumn #12947

wants to merge 28 commits into from

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Oct 15, 2024 •
edited
Loading

Which issue does this PR close?

Closes #.
POC for checking #12944 , not for merged

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Rachelint and others added 28 commits October 8, 2024 14:35
@Rachelint
define ByteGroupValueViewBuilder.
ca033e0
@Rachelint
impl append.
ffcc1a2
@Rachelint
impl equal to.
4842965
@Rachelint
fix compile.
66bb7be
@Rachelint
fix comments.
ef1efce
@Rachelint
impl take_n.
152a8b1
@Rachelint
impl build.
d61c3ec
@Rachelint
impl rest functions in GroupColumn.
151377e
@Rachelint
fix output when panic.
63e11cb
@Rachelint
add e2e sql tests.
15d8349
@Rachelint
add unit tests.
d9ee724
@Rachelint
switch to a really elegant style codes from alamb.
beffa35
@Rachelint
fix take_n.
46822f9
@Rachelint
improve comments.
3a93584
@Rachelint
fix compile.
f99f55c
@Rachelint
fix clippy.
37b4816
@Rachelint
define more testcases in test_byte_view_take_n.
d78c68d
@Rachelint
connect up.
7cb7dfc
@Rachelint
fix doc.
e6c7e7e
@alamb
Do not re-validate output is utf8
36d556e
@Rachelint
Merge pull request #1 from alamb/alamb/tweak-group
f76c376 
Do not re-validate output is utf8
@Rachelint
switch to unchecked when building array.
1fd926f
@Rachelint
improve naming.
34918cb
@Rachelint
use let else to make the codes clearer.
8348024
@Rachelint
fix typo.
023ed64
@Rachelint
improve unit test coverage for ByteViewGroupValueBuilder.
c4d45c7
@alamb
Merge remote-tracking branch 'apache/main' into impl-byte-view-column
a1f8d0c
@Rachelint
tmp
6e63eec
@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Oct 15, 2024
@Rachelint Rachelint mentioned this pull request Oct 15, 2024
Closed
@Rachelint
Copy link
Contributor Author

Rachelint commented Oct 16, 2024 •
edited
Loading

I found it actually now a trivial change.
The challenge is that, we should refactor codes to support vectorize append firstly
(otherwise, we need to add a branch for row's appending, and as a reuslt, we remove a row level branch and add another...)

I am trying it.

@Rachelint
Copy link
Contributor Author

It is poc version of #12996

@Rachelint Rachelint closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rachelint @alamb