Implement GroupsAccumulator for corr(x,y) aggregate function #13581
+513
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13549
Rationale for this change
Implement
GroupsAccumulator
forcorr
aggregation function, for better performance when group cardinality is highI rerun the H2o benchmark:
Data Generation
falsa groupby --path-prefix=/Users/yongting/data/ --size MEDIUM --data-format PARQUET
https://github.com/mrpowers-io/falsa
Run benchmark in datafusion-cli
Result
Main: 12s
This PR: 4s
(On my MacBook with m4 pro)
Remaining tasks
convert_to_states()
What changes are included in this PR?
accumulate_multiple
andaccumulate_correlation_states
to accumulate states in correlation function. (existing util functions is for aggregate functions with 1 input expravg(expr1) v.s. corr(expr1, expr2)
)GroupsAccumulator
forcorr()
Are these changes tested?
Unit tests for util functions
corr()
is covered by existing testsAre there any user-facing changes?
No