Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add documentation explaining that initcap only works for ASCII #13749

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 12, 2024

Which issue does this PR close?

Rationale for this change

@tlm365 says: #13691 (comment)

@Dandandan you're right. I tested it with some unit tests for special characters (unicode), this PR's implementation doesn't work and the old implementation doesn't work either. But I think it makes sense at the moment since the initcap function is in datafusion::function::string not datafusion::function::unicode.

Perhaps, it would be better if we update the documentation that initcap is not supported for unicode characters yet and try to handle it if necessary in another PR.

What changes are included in this PR?

Update docs to reflect the caveat that init cap only works on ASCII strings

Are these changes tested?

by CI

Are there any user-facing changes?

Just docs, no functional change

@github-actions github-actions bot added documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt) functions labels Dec 12, 2024
@alamb alamb force-pushed the alamb/document_init_cap branch from 7056ded to d14a711 Compare December 12, 2024 22:39
@github-actions github-actions bot removed the sqllogictest SQL Logic Tests (.slt) label Dec 12, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit b69fa67 into apache:main Dec 13, 2024
27 checks passed
@comphead comphead changed the title Minor: Add documentation explaining that initcap oly works for ASCII Minor: Add documentation explaining that initcap only works for ASCII Dec 13, 2024
@alamb alamb deleted the alamb/document_init_cap branch December 13, 2024 18:02
@alamb
Copy link
Contributor Author

alamb commented Dec 13, 2024

Thank you for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants