doc-gen: migrate scalar functions (string) documentation 2/4 #13925
Conversation
|
Did you run the doc generation script prior to pushing this change? The doc diff seems ... odd |
github-actions
bot
added
the
documentation
| @@ -1697,8 +1697,8 @@ upper(str) | |||
|
|
|||
| **Related functions**: | |||
|
|
|||
| - [initcap](#initcap) | |||
| - [lower](#lower) | |||
There was a problem hiding this comment.
hm, why we have this change? 🤔 its not critical but last revision was better as it sorted
There was a problem hiding this comment.
Ah, I overlooked the sorting part. You're right. I'll revert it back. Thanks for catching this! 👍
| @@ -971,8 +971,8 @@ concat_ws(separator, str[, ..., str_n]) | |||
|
|
|||
| #### Arguments | |||
|
|
|||
| - **separator**: Separator to insert between concatenated strings. | |||
| - **str**: String expression to operate on. Can be a constant, column, or function, and any combination of operators. | |||
There was a problem hiding this comment.
I think separator should come first in order like it is in the function signature
There was a problem hiding this comment.
I tried changing the order between argument and standard argument in user_doc(), but the documentation order didn't change. Is the order of content sections fixed?
There was a problem hiding this comment.
The problem is the mixed argument and standard_argument and then again argument. Pretty rare edge case
|
@Chen-Yuan-Lai please take latest updates from your branch and run |
github-actions
bot
removed
the
documentation
Chen-Yuan-Lai
force-pushed
the
migrate_scalar_functions_string_2/4
branch
from
214bbe3 to
8c037ad
Compare
Which issue does this PR close?
Part of #13671 .
Rationale for this change
What changes are included in this PR?
As discussed in #13671 , this PR will migrate the parts of builtin string functions documentation that currently support migration.
Are these changes tested?
Are there any user-facing changes?