Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update sqllogictest requirement from 0.24.0 to 0.25.0 (#13917)" #13945

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 30, 2024

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

pin to sqllogictest 0.24.0 and add a note about why

Are these changes tested?

By CI

Are there any user-facing changes?

No this is development tooling

@alamb alamb added the development-process Related to development process of DataFusion label Dec 30, 2024
@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels Dec 30, 2024
@alamb alamb changed the title Alamb/downgrade sqllogictest Revert "Update sqllogictest requirement from 0.24.0 to 0.25.0 (#13917)" Dec 30, 2024
@alamb alamb marked this pull request as ready for review December 30, 2024 11:39
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alamb

@jonahgao jonahgao merged commit 3ea1b6a into apache:main Dec 30, 2024
29 checks passed
@alamb alamb deleted the alamb/downgrade_sqllogictest branch December 30, 2024 18:02
@alamb
Copy link
Contributor Author

alamb commented Dec 30, 2024

Thanks for the review @jonahgao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants