Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate example dataframe_subquery.rs into dataframe.rs #13950

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Consolidate example dataframe_subquery.rs into dataframe.rs #13950

merged 1 commit into from
Dec 31, 2024

Conversation

zjregee
Copy link
Member

@zjregee zjregee commented Dec 31, 2024

Which issue does this PR close?

Closes #13911.

Rationale for this change

  1. Make it easier to find relevant examples.
  2. Make local dev faster with fewer distinct binary targets (each example binary takes 100+ MB to compile).

What changes are included in this PR?

Consolidate example dataframe_subquery.rs into dataframe.rs.

Are these changes tested?

Tested by CI.

Are there any user-facing changes?

None.

alamb
alamb approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @zjregee -- looks like a very nice improvement to me ❤️

@alamb alamb merged commit 2b15ad1 into apache:main Dec 31, 2024
26 checks passed
@alamb alamb added the documentation Improvements or additions to documentation label Dec 31, 2024
@alamb alamb mentioned this pull request Jan 1, 2025
Open
11 tasks
@zjregee zjregee deleted the consolidate-example branch January 2, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate Example: dataframe_subquery.rs into dataframe.rs
2 participants
@zjregee @alamb