Update release instructions for 44.0.0 #13959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
phillipleblanc
approved these changes
Jan 1, 2025
comphead
reviewed
Jan 2, 2025
| @@ -274,13 +274,16 @@ Verify that the Cargo.toml in the tarball contains the correct version | |||
| (cd datafusion/physical-expr-common && cargo publish) | |||
| (cd datafusion/functions-aggregate-common && cargo publish) | |||
| (cd datafusion/functions-window-common && cargo publish) | |||
| (cd datafusion/doc && cargo publish) | |||
| (cd datafusion/macros && cargo publish) | |||
There was a problem hiding this comment.
do we really need to publish these? 🤔
I had to publish them as several of the other crates depend on them. For example, (I (re)discovered the new crates when I tried to publish version 44 and cargo wouldn't do so without having the docs and macros crates pubished first) |
|
Thanks @comphead and @phillipleblanc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
44.0.0#13334Rationale for this change
New crates got added as part of this release so we need to add them
What changes are included in this PR?
Update release instructions
Are these changes tested?
Are there any user-facing changes?