Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ScalarUDFImpl docs #14248

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Improve ScalarUDFImpl docs #14248

merged 2 commits into from
Jan 23, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 23, 2025

Which issue does this PR close?

Rationale for this change

While messing around with other things I noticed there was some documentation that could be improved on

What changes are included in this PR?

Improve some doc comments

Are these changes tested?

Yes, by CI

Are there any user-facing changes?

Just docs, no functional changes

@alamb alamb added the documentation Improvements or additions to documentation label Jan 23, 2025
@github-actions github-actions bot added logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels Jan 23, 2025
@alamb alamb changed the title Improve docs Improve ScalarUDFImpl docs Jan 23, 2025
@alamb alamb added the documentation Improvements or additions to documentation label Jan 23, 2025
@alamb alamb marked this pull request as ready for review January 23, 2025 11:28
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the doc from the newcomer's perspective, lgtm, thanks @alamb

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 23, 2025
@alamb
Copy link
Contributor Author

alamb commented Jan 23, 2025

Thank you @xudong963 for the quick review!

@alamb alamb added the documentation Improvements or additions to documentation label Jan 23, 2025
@alamb alamb merged commit 27db82f into apache:main Jan 23, 2025
25 checks passed
@alamb alamb deleted the alamb/mo_mo_docs branch January 23, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants