-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Refactor CI builders #8826
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
62db476
[CI] Test Mozilla sccache to make compile faster
comphead a502430
linux and macos make datafusion cli a sep job
comphead e4ffe9f
split conf
comphead 7506917
fix conf
comphead 20ca32a
fix macos
comphead 1620e12
reformat runtime
comphead 4e1975a
try win container
comphead 83963f4
win
comphead d9d8e36
refactor
comphead fd2edb2
reformat
comphead ba37bd7
disable backtrace for win
comphead 361d455
reformat
comphead 80a5809
revert
comphead 299aae7
Update .github/actions/setup-macos-builder/action.yaml
comphead 94a5b50
Update .github/actions/setup-windows-builder/action.yaml
comphead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
name: Prepare Rust Builder for MacOS | ||
description: 'Prepare Rust Build Environment for MacOS' | ||
inputs: | ||
rust-version: | ||
description: 'version of rust to install (e.g. stable)' | ||
required: true | ||
default: 'stable' | ||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Install protobuf compiler | ||
shell: bash | ||
run: | | ||
mkdir -p $HOME/d/protoc | ||
cd $HOME/d/protoc | ||
export PROTO_ZIP="protoc-21.4-osx-x86_64.zip" | ||
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP | ||
unzip $PROTO_ZIP | ||
echo "$HOME/d/protoc/bin" >> $GITHUB_PATH | ||
export PATH=$PATH:$HOME/d/protoc/bin | ||
protoc --version | ||
- name: Setup Rust toolchain | ||
shell: bash | ||
run: | | ||
rustup update stable | ||
rustup toolchain install stable | ||
rustup default stable | ||
rustup component add rustfmt | ||
- name: Configure rust runtime env | ||
uses: ./.github/actions/setup-rust-runtime |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
name: Setup Rust Runtime | ||
description: 'Setup Rust Runtime Environment' | ||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Run sccache-cache | ||
uses: mozilla-actions/[email protected] | ||
- name: Configure runtime env | ||
shell: bash | ||
# do not produce debug symbols to keep memory usage down | ||
# hardcoding other profile params to avoid profile override values | ||
# More on Cargo profiles https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings | ||
# | ||
# Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow build | ||
# See for more details: https://github.com/rust-lang/rust/issues/119560 | ||
# | ||
# set RUST_MIN_STACK to avoid rust stack overflows on tpc-ds tests | ||
run: | | ||
echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV | ||
echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV | ||
echo "RUST_BACKTRACE=1" >> $GITHUB_ENV | ||
echo "RUST_MIN_STACK=3000000" >> $GITHUB_ENV | ||
echo "RUST_FLAGS=-C debuginfo=line-tables-only -C incremental=false" >> $GITHUB_ENV | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
name: Prepare Rust Builder for Windows | ||
description: 'Prepare Rust Build Environment for Windows' | ||
inputs: | ||
rust-version: | ||
description: 'version of rust to install (e.g. stable)' | ||
required: true | ||
default: 'stable' | ||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Install protobuf compiler | ||
shell: bash | ||
run: | | ||
mkdir -p $HOME/d/protoc | ||
cd $HOME/d/protoc | ||
export PROTO_ZIP="protoc-21.4-win64.zip" | ||
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP | ||
unzip $PROTO_ZIP | ||
export PATH=$PATH:$HOME/d/protoc/bin | ||
protoc.exe --version | ||
- name: Setup Rust toolchain | ||
shell: bash | ||
run: | | ||
rustup update stable | ||
rustup toolchain install stable | ||
rustup default stable | ||
rustup component add rustfmt | ||
- name: Configure rust runtime env | ||
uses: ./.github/actions/setup-rust-runtime |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put this as a TODO item, since ideally we'd want the tests to pass without needing this setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need it as TPC-DS tests spontaneously fail on stack overflow. But we prob need to check why is it happening. That might be a bigger problem with piling up the stackframes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be great to file a ticket to track the stack overflow
https://github.com/apache/arrow-datafusion/issues?q=is%3Aissue+is%3Aopen+stack+overflow doesn't show any obvious candidate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #8837