Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9580 .
Rationale for this change
AT TIME ZONE
clause wasn't supported by DataFusion. For eg:SELECT '2000-12-01 04:04:12' AT TIME ZONE 'America/New_York');
would earlier lead to this error:
This feature is not implemented: Unsupported ast node in sqltorel: AtTimeZone
Now, the query evaluates to:
What changes are included in this PR?
This PR adds support for converting
AtTimeZone
expression provided bysqlparser-rs
to a logical expression in DataFusion.Are these changes tested?
Yes. New tests have been added for expected behaviour and error scenarios.
Are there any user-facing changes?
Yes. The addition of
AT TIME ZONE
clause is a user facing change.No breaking change since this PR only adds support for a previously unsupported clause.