Move radians, signum, sin, sinh and sqrt functions to datafusion-functions crate
#9882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
erenavsarogullari
changed the title
Radians, Signum, Sin, Sinh, Sqrt functions to datafusion-functions crateradians, signum, sin, sinh and sqrt functions to datafusion-functions crate
erenavsarogullari
changed the title
radians, signum, sin, sinh and sqrt functions to datafusion-functions crateradians, signum, sin, sinh and sqrt functions to datafusion-functions crate
erenavsarogullari
changed the title
radians, signum, sin, sinh and sqrt functions to datafusion-functions crateradians, signum, sin, sinh and sqrt functions to datafusion-functions crate
|
Current test failures due to #9891 |
alamb
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Looks great to me -- thank you @erenavsarogullari 🙏
I took the liberty of merging up from main to get the CI passing on this PR
|
🤔 there seems to be one more CI failure related to this PR |
|
Thanks for the review. CI failure has been addressed. |
Weijun-H
approved these changes
Apr 2, 2024
|
🚀 -- thanks @Weijun-H and @erenavsarogullari ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9860.
What changes are included in this PR?
radians,signum,sin,sinhandsqrtfunctions are moved todatafusion-functionscrate.Are these changes tested?
Yes, all
scalar.sltbasedradians,signum,sin,sinhandsqrtfunctions' tests are passed.Are there any user-facing changes?
No