Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for for AggregateUDFImpl with ORDER BY and IGNORE NULLS #9953

Closed
wants to merge 1 commit into from
Closed

Add test for for AggregateUDFImpl with ORDER BY and IGNORE NULLS #9953

wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 4, 2024

This PR has some tests I wrote for testing user defined aggregates with ORDER BY and IGNORE NULLS for #9920 that I removed

However, I think the tests could be useful for #9924 so I made a PR to store them

@alamb alamb closed this Apr 4, 2024
@github-actions github-actions bot added the core Core DataFusion crate label Apr 4, 2024
alamb
alamb commented Apr 4, 2024
View reviewed changes
datafusion/core/tests/user_defined/user_defined_aggregates.rs
ctx.sql(sql).await.unwrap().collect().await.unwrap();
}

// You can pass IGNORE NULLs to the UDAF
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are the tests

@alamb alamb mentioned this pull request Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alamb