move Floor, Gcd, Lcm, Pi to datafusion-functions #9976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
jackwener
approved these changes
Apr 7, 2024
|
Thanks @jackwener - may I ask what you see as a behaviour change? From my understanding there shouldn't be any user facing changes beyond where a function is located in the code (for dataframe use cases). Did I miss/change something inadvertently (it's happened before ...) ? |
jackwener
reviewed
Apr 7, 2024
| use crate::utils::make_scalar_function; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct LcmFunc { |
There was a problem hiding this comment.
I don't believe so - this is following the pattern set out in #9903
my mistake, sorry for it. |
jackwener
approved these changes
Apr 8, 2024
comphead
approved these changes
Apr 8, 2024
|
Will merge it before the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9861
Rationale for this change
Function migration.
What changes are included in this PR?
code, tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.