-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Modify the documentation of functions of array, array_apply, array_avg, array_compact, array_concat,array_cum_sum,array_difference #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrySnow
reviewed
Jan 20, 2025
## Parameters | ||
| Parameter | Description | | ||
|---|---| | ||
| `<arr>` | ARRAY | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同样的需要更好的描述
morrySnow
reviewed
Jan 20, 2025
Comment on lines
37
to
38
| `<arr1>` | ARRAY array | | ||
| `<arr2>` | ARRAY array | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个参数说明也要改一下~
KassieZ
added
has comments
Some comments not resolved yet
and removed
request review
labels
Jan 20, 2025
KassieZ
added
request review
and removed
has comments
Some comments not resolved yet
labels
Jan 22, 2025
morrySnow
reviewed
Jan 22, 2025
|
||
`ARRAY<T> array(T, ...)` | ||
```sql | ||
array(<T>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 参数用小写字母
- 参数名可以起的有意义一些
- 可变参数需要增加
[, ...]
- array 函数可以没有参数,所有需要将整个参数列表作为可选参数
Suggested change
array(<T>) | |
array([ <element> [, ...] ]) |
morrySnow
approved these changes
Jan 22, 2025
ixzc
force-pushed
the
fix_array_function_manual3
branch
from
January 23, 2025 06:06
783c1df
to
24f8d16
Compare
ixzc
force-pushed
the
fix_array_function_manual3
branch
from
January 23, 2025 06:49
e19b60f
to
24f8d16
Compare
…ray_avg, array_compact, array_concat,array_cum_sum,array_difference
ixzc
force-pushed
the
fix_array_function_manual3
branch
from
January 23, 2025 06:52
24f8d16
to
89c5fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the documentation of functions of array, array_apply, array_avg, array_compact, array_concat,array_cum_sum,array_difference
Versions
Languages
Docs Checklist