Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Modify the documentation of functions of array, array_apply, array_avg, array_compact, array_concat,array_cum_sum,array_difference #1865

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

ixzc
Copy link
Contributor

@ixzc ixzc commented Jan 18, 2025

Modify the documentation of functions of array, array_apply, array_avg, array_compact, array_concat,array_cum_sum,array_difference

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

## Parameters
| Parameter | Description |
|---|---|
| `<arr>` | ARRAY |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同样的需要更好的描述

Comment on lines 37 to 38
| `<arr1>` | ARRAY array |
| `<arr2>` | ARRAY array |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个参数说明也要改一下~

@KassieZ KassieZ added has comments Some comments not resolved yet and removed request review labels Jan 20, 2025
@ixzc ixzc requested a review from morrySnow January 22, 2025 02:42
@KassieZ KassieZ added request review and removed has comments Some comments not resolved yet labels Jan 22, 2025

`ARRAY<T> array(T, ...)`
```sql
array(<T>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 参数用小写字母
  2. 参数名可以起的有意义一些
  3. 可变参数需要增加 [, ...]
  4. array 函数可以没有参数,所有需要将整个参数列表作为可选参数
Suggested change
array(<T>)
array([ <element> [, ...] ])

@ixzc ixzc requested a review from morrySnow January 22, 2025 07:47
@morrySnow morrySnow requested a review from KassieZ January 22, 2025 12:46
@ixzc ixzc force-pushed the fix_array_function_manual3 branch from 783c1df to 24f8d16 Compare January 23, 2025 06:06
@ixzc ixzc force-pushed the fix_array_function_manual3 branch from e19b60f to 24f8d16 Compare January 23, 2025 06:49
@ixzc ixzc force-pushed the fix_array_function_manual3 branch from 24f8d16 to 89c5fde Compare January 23, 2025 06:52
@KassieZ KassieZ merged commit 4099ea0 into apache:master Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants