Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix plugin related documentation #1911

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xyfsjq
Copy link
Contributor

@xyfsjq xyfsjq commented Jan 22, 2025

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

评论的几个问题,是共性的问题。麻烦把所有文档都检查修改一遍吧


```sql
INSTALL PLUGIN FROM [source] [PROPERTIES ("key"="value", ...)]
INSTALL PLUGIN FROM source [PROPERTIES ("key"="value", ...)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
INSTALL PLUGIN FROM source [PROPERTIES ("key"="value", ...)]
INSTALL PLUGIN FROM <source> [PROPERTIES ("<key>"="<value>", ...)]

Comment on lines 40 to 44
- source
The plugin path to be installed, supports three types:
1. An absolute path to a zip file
2. An absolute path to a plugin directory
3. Points to a zip file download path with http or https protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 使用有序列表
  2. 带上尖括号,使用 inline code
  3. 加粗
  4. 说明的地方使用引用
Suggested change
- source
The plugin path to be installed, supports three types:
1. An absolute path to a zip file
2. An absolute path to a plugin directory
3. Points to a zip file download path with http or https protocol
** 1. `<source>`**
> The plugin path to be installed, supports three types:
> 1. An absolute path to a zip file
> 2. An absolute path to a plugin directory
> 3. Points to a zip file download path with http or https protocol


| Permissions | Object | Notes |
|:-----------|:-----|:--------------|
| Admin_priv | The entire cluster | Requires administrative privileges for the entire cluster |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Admin_priv | The entire cluster | Requires administrative privileges for the entire cluster |
| ADMIN_PRIV | The entire cluster | Requires administrative privileges for the entire cluster |

Comment on lines 40 to 44
|Description|Version|JavaVersion|ClassName|SoName|Sources|Status|Properties|
|-----------|-------|-----------|---------|------|-------|------|----------|
|builtin audit loader, to load audit log to internal table|2.1.0|1.8.31|org.apache.doris.plugin.audit.AuditLoader||Builtin|INSTALLED|{}|
|builtin audit logger|0.12.0|1.8.31|org.apache.doris.plugin.audit.AuditLogBuilder||Builtin|INSTALLED|{}|
|builtin sql dialect converter|2.1.0|1.8.31|org.apache.doris.plugin.dialect.HttpDialectConverterPlugin||Builtin|INSTALLED|{}|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是要说明返回的结果,每一列的含义。而不是给一个返回值的示例

Comment on lines 58 to 60
```SQL
SHOW PLUGINS;
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个后面,要把SHOW PLUGINS; 的结果写出来

@@ -29,27 +29,33 @@ under the License.

This statement is used to uninstall a plugin.

grammar:
## Syntax:

```sql
UNINSTALL PLUGIN plugin_name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UNINSTALL PLUGIN plugin_name;
UNINSTALL PLUGIN <plugin_name>;


Only non-builtin plugins can be uninstalled.
- plugin_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类似的问题

@KassieZ KassieZ added the has comments Some comments not resolved yet label Jan 23, 2025
@xyfsjq xyfsjq requested a review from morrySnow January 23, 2025 12:23

## Optional parameters

** 1. `<PROPERTIES>`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** 1. `<PROPERTIES>`**
** 1. `[PROPERTIES ("<key>"="<value>", ...)]`**

Comment on lines 40 to 42
|Description| Version | JavaVersion | ClassName | SoName | Sources | Status | Properties |
|-----------|---------|-------------|------|----------|------|------|-------|
|Corresponding plug-in description| Plug-in corresponding version number | Corresponding Java version number | Program class name | Program shared object name | Plugin Source | Installation Status | Plugin Properties |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| Column | Description |
| ------ | ----------- |
| Description | Corresponding plug-in description |
| .... | .... |
| Properties | Plugin Properties |

Comment on lines 61 to 65
|Description|Version|JavaVersion|ClassName|SoName|Sources|Status|Properties|
|-----------|-------|-----------|---------|------|-------|------|----------|
|builtin audit loader, to load audit log to internal table|2.1.0|1.8.31|org.apache.doris.plugin.audit.AuditLoader||Builtin|INSTALLED|{}|
|builtin audit logger|0.12.0|1.8.31|org.apache.doris.plugin.audit.AuditLogBuilder||Builtin|INSTALLED|{}|
|builtin sql dialect converter|2.1.0|1.8.31|org.apache.doris.plugin.dialect.HttpDialectConverterPlugin||Builtin|INSTALLED|{}|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方要用 mysql 客户端执行出来的返回结果。形如

+----+-----+
| .. | ... |
....

@xyfsjq xyfsjq requested a review from morrySnow January 24, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has comments Some comments not resolved yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants