Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-2.1: [fix](nereids) fix merge_percentile_to_array when has same agg function #44783 #44879

Open
wants to merge 1 commit into
base: branch-2.1
Choose a base branch
from

Commits on Dec 2, 2024

  1. [fix](nereids) fix merge_percentile_to_array when has same agg functi…

    …on (#44783)
    
    Related PR: #34313
    
    Problem Summary
    The original PR did not handle the following scenario:
    ```sql
    SELECT SUM(a), PERCENTILE(pk, 0.1) AS c1, PERCENTILE(pk, 0.1) AS c2, PERCENTILE(pk, 0.4) AS c3 FROM test_merge_percentile;
    ```
    In this case, the aggregate outputs include two identical functions
    (PERCENTILE(pk, 0.1)). When constructing the LogicalProject, a map was
    used where the key is the child of an Alias and the value is the Alias
    itself. However, this approach loses information when two Aliases share
    the same child.
    This PR modifies the map structure to use the child of an Alias as the
    key and a list of Alias objects as the value. This ensures that all
    Alias instances with the same child are preserved, resolving the issue
    of lost information in such cases.
    feiniaofeiafei authored and Your Name committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    a96602e View commit details
    Browse the repository at this point in the history