Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Name Mapping #526

Closed
wants to merge 55 commits into from
Closed

Service Name Mapping #526

wants to merge 55 commits into from

Conversation

mark4z
Copy link
Member

@mark4z mark4z commented Nov 21, 2022

What this PR does:
#485
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Still some leftovers to do, but mostly usable
Does this PR introduce a user-facing change?:


@mark4z mark4z changed the title [WIP]Service Name Mapping Service Name Mapping Nov 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #526 (6b7ff6f) into develop (9db643e) will decrease coverage by 0.37%.
The diff coverage is 70.18%.

@@             Coverage Diff             @@
##           develop     #526      +/-   ##
===========================================
- Coverage    55.13%   54.75%   -0.38%     
===========================================
  Files          667      667              
  Lines        79061    78131     -930     
===========================================
- Hits         43590    42781     -809     
+ Misses       31784    31701      -83     
+ Partials      3687     3649      -38     
Impacted Files Coverage Δ
pilot/pkg/model/push_context.go 57.03% <34.14%> (-5.81%) ⬇️
...working/dubbo/v1alpha1/servicenamemappingserver.go 69.51% <69.51%> (-6.12%) ⬇️
pilot/pkg/config/kube/crdclient/types.gen.go 79.56% <95.74%> (-2.35%) ⬇️
pilot/pkg/bootstrap/server.go 53.44% <100.00%> (-9.38%) ⬇️
pilot/pkg/xds/ads.go 72.90% <100.00%> (-0.87%) ⬇️
pilot/pkg/xds/discovery.go 85.98% <100.00%> (-2.06%) ⬇️
security/pkg/credentialfetcher/fetcher.go 40.00% <0.00%> (-20.00%) ⬇️
pkg/channels/unbounded.go 95.83% <0.00%> (-4.17%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mark4z mark4z requested review from PhilYue and ztelur November 26, 2022 10:56
@mark4z mark4z closed this Nov 29, 2022
@mark4z mark4z reopened this Nov 29, 2022
@apache apache deleted a comment from sonarqubecloud bot Nov 29, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.3% 4.3% Duplication

@AlexStocks
Copy link
Contributor

远云近期还在写文档,大概下下周可以抽时间测试这个 pr

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mark4z mark4z closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants