Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the ability to pull the logger configuration from nacos at program startup #640

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

mutezebra
Copy link
Contributor

What this PR does:

Provides the ability to load the logger configuration from Nacos at the beginning of the program

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Copy link

sonarqubecloud bot commented Nov 8, 2024

@AlexStocks AlexStocks requested a review from mark4z November 17, 2024 12:16
@AlexStocks
Copy link
Contributor

@silver-bullet

pkg/model/log.go Outdated Show resolved Hide resolved
@No-SilverBullet
Copy link
Contributor

LGTM

@baerwang baerwang merged commit b590ac6 into apache:develop Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants