Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Remove the configuration to avoid impacting users' default configuration values. #15058

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Stellar1999
Copy link
Contributor

What is the purpose of the change?

fix issue #15050

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@Stellar1999 Stellar1999 changed the title fix:Remove the configuration to avoid impacting users' default configuration values. (#15050) fix:Remove the configuration to avoid impacting users' default configuration values. Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.72%. Comparing base (f0dd47a) to head (b66fc03).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15058      +/-   ##
============================================
- Coverage     60.74%   60.72%   -0.02%     
+ Complexity    10863    10861       -2     
============================================
  Files          1882     1882              
  Lines         86007    86007              
  Branches      12886    12886              
============================================
- Hits          52243    52226      -17     
- Misses        28314    28328      +14     
- Partials       5450     5453       +3     
Flag Coverage Δ
integration-tests 32.98% <ø> (-0.06%) ⬇️
samples-tests 29.21% <ø> (+<0.01%) ⬆️
unit-tests 58.89% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit 2582d78 into apache:3.3 Jan 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants