-
Notifications
You must be signed in to change notification settings - Fork 179
[EAGLE-906] org.apache.storm 1.x with API changes #812
base: master
Are you sure you want to change the base?
Conversation
@jhsenjaliya building failed, could you please check again? |
ea74430
to
51ed88c
Compare
Have you tested about consuming |
i havent explicitly tested it, but from storm-kafka:1.0.2 docs, it looks compatible with kafka 0.8.1.1 which is used in the example given on that page. |
Just worry about possible compatibility issue as |
ok, I m digging further into this, I will try running some apps. pls let me know if you have any other suggestions. |
ce016cf
to
0ac0657
Compare
@haoch, I tested all of these change with kafka_2.11-0.8.2.2 and it works fine. |
need to rebase branch-0.5-storm_1.x with master. changing the base to master for time being. |
i will update this PR with storm 1.1.0 and rebase it after 0.5 release. |
@jhsenjaliya In my opition , I don't think it is good time to upgrade storm to 1.1.0. In my experience ,many companies do not use the latest version .If you insist to upgrade storm, I recommend we should support multi storm version (like hive shims moudle) and do more integration test instead of unit test by mock. |
@r7raul1984 , that is a good point, but this is intended for 0.6 release which will have enough time to take a minor versions with bug fixes if any ( or we can also simply stick to 1.0.x but I would like to compare both 1.0.x and 1.1.x in terms of improvements before change) . I also agree on exploring a way to support multi version shims way. |
tested on MR Running and MR history app.